Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] request explicit input source #163

Merged
merged 5 commits into from
Nov 21, 2024
Merged

[Task] request explicit input source #163

merged 5 commits into from
Nov 21, 2024

Conversation

mattamon
Copy link
Contributor

Resolves #114

@mattamon mattamon added this to the 1.8.0 milestone Nov 21, 2024
@mattamon mattamon marked this pull request as draft November 21, 2024 07:53
@mattamon mattamon marked this pull request as ready for review November 21, 2024 08:01
@kingjia90 kingjia90 self-assigned this Nov 21, 2024
kingjia90
kingjia90 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@kingjia90 kingjia90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some indirect changes required after dropping 10, the rest LGTM
Thank you!

composer.json Outdated Show resolved Hide resolved
.github/workflows/static-analysis.yml Outdated Show resolved Hide resolved
kingjia90
kingjia90 reviewed Nov 21, 2024
View reviewed changes
doc/01_Installation.md Outdated Show resolved Hide resolved
@mattamon mattamon requested a review from kingjia90 November 21, 2024 14:46
@mattamon mattamon merged commit f8fe966 into 1.x Nov 21, 2024
3 checks passed
@mattamon mattamon deleted the 114-request-input-explicit branch November 21, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 approved these changes

Assignees

@kingjia90 kingjia90

Labels
Pimcore:ToDo Task
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Replace Request::get with explicit input sources
2 participants
@mattamon @kingjia90